Explicitly use ISO weekfields for weekyear date formats #113787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoop
added
:Core/Infra/Core
|
Documentation preview: |
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
thecoop
force-pushed
the
iso-weekfields
branch
from
e1f8795 to
f16d4c1
Compare
thecoop
commented
Sep 30, 2024
| // fill the rest of the date up with the parsed date | ||
| if (accessor.isSupported(ChronoField.YEAR) == false | ||
| && accessor.isSupported(ChronoField.YEAR_OF_ERA) == false | ||
| && accessor.isSupported(WeekFields.ISO.weekBasedYear()) == false |
There was a problem hiding this comment.
These additions, and similar, are because ISO.weekBasedYear is a different thing to of(locale).weekBasedYear, even though they probably represent the same thing
thecoop
added a commit
to thecoop/elasticsearch
that referenced
this pull request
Oct 1, 2024
…stic#113787) This is so it doesn't change when changing JDK version and locale database
thecoop
added a commit
to thecoop/elasticsearch
that referenced
this pull request
Oct 1, 2024
…stic#113787) This is so it doesn't change when changing JDK version and locale database
thecoop
added a commit
that referenced
this pull request
Oct 2, 2024
gmarouli
pushed a commit
to gmarouli/elasticsearch
that referenced
this pull request
Oct 3, 2024
…stic#113870) Forward-port changes from elastic#113787, and update the docs with similar information to elastic#113587
matthewabbott
pushed a commit
to matthewabbott/elasticsearch
that referenced
this pull request
Oct 4, 2024
…stic#113870) Forward-port changes from elastic#113787, and update the docs with similar information to elastic#113587
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrary to what you might think, this is actually maintaining existing behaviour when run on JDK 22 and 23.
IsoCalendarDataProvideroverrides the root locale weekyear to use ISO, which effectively means we are already using ISO for all week-based date formats. Changing to JDK 23 means the locale-based ones use Sunday/1-day for weekfield definitions, so setting this to explicitly ISO is maintaining the existing behaviour. It also makes all week-date formats definitely use ISO definitions.This is aimed at 8.x, as that's where all the docs are targetting. When we're all settled on the various PRs, I'll forward-port this to main, along with any relevant locale docs already merged into 8.x